Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove code related to the gas based staking pools #144

Merged
merged 4 commits into from
Nov 23, 2023
Merged

Remove code related to the gas based staking pools #144

merged 4 commits into from
Nov 23, 2023

Conversation

dandheedge
Copy link
Contributor

Fixes #143

@vercel
Copy link

vercel bot commented Oct 16, 2023 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
staking ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 21, 2023 6:32am

@github-actions
Copy link

github-actions bot commented Oct 16, 2023 •
edited

Pull Request Test Coverage Report for Build 6940132476

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+4.6%) to 77.361%
Totals Coverage Status
Change from base Build 6737463225: 4.6%
Covered Lines: 338
Relevant Lines: 401
💛 - Coveralls

@dandheedge dandheedge marked this pull request as ready for review October 17, 2023 00:59
@dandheedge dandheedge self-assigned this Oct 17, 2023
@dandheedge dandheedge added type:refactor A code change that neither fixes a bug nor adds a feature staking Changes targeted to the Staking platform labels Oct 17, 2023
brunomenezes
brunomenezes requested changes Oct 19, 2023
View reviewed changes
Copy link
Collaborator

@brunomenezes brunomenezes left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @dandheedge,
There are still some pieces of code to be cleaned.

I mentioned these in the issue here

nevendyulgerov
nevendyulgerov previously approved these changes Oct 27, 2023
View reviewed changes
Copy link
Contributor

@nevendyulgerov nevendyulgerov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I just noticed a couple of messages that we may also want to remove:

  • /staking/src/utils/labels.ts - gasTaxCommission
  • /staking/src/utils/messages.ts - messages.commission.model.gasBased

@brunomenezes
Copy link
Collaborator

LGTM! I just noticed a couple of messages that we may also want to remove:

  • /staking/src/utils/labels.ts - gasTaxCommission
  • /staking/src/utils/messages.ts - messages.commission.model.gasBased

Hey @dandheedge,
Do you mind removing these as well before we merge?

@brunomenezes
Copy link
Collaborator

LGTM! I just noticed a couple of messages that we may also want to remove:

  • /staking/src/utils/labels.ts - gasTaxCommission
  • /staking/src/utils/messages.ts - messages.commission.model.gasBased

Hey @dandheedge, Do you mind removing these as well before we merge?

Just giving a nudge on that before we merge cc: @dandheedge

@dandheedge dandheedge force-pushed the refactor/143-remove-code-related-to-the-gas-based-staking-pools branch from aa3d674 to 32f542c Compare November 21, 2023 06:29
@dandheedge
Copy link
Contributor Author

LGTM! I just noticed a couple of messages that we may also want to remove:

  • /staking/src/utils/labels.ts - gasTaxCommission
  • /staking/src/utils/messages.ts - messages.commission.model.gasBased

Hey @dandheedge, Do you mind removing these as well before we merge?

Just giving a nudge on that before we merge cc: @dandheedge

@brunomenezes @nevendyulgerov already removed it

@brunomenezes brunomenezes merged commit 94b35d5 into main Nov 23, 2023
6 of 7 checks passed
@brunomenezes brunomenezes deleted the refactor/143-remove-code-related-to-the-gas-based-staking-pools branch November 23, 2023 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brunomenezes brunomenezes brunomenezes approved these changes

@nevendyulgerov nevendyulgerov Awaiting requested review from nevendyulgerov

Assignees

@dandheedge dandheedge

Labels
staking Changes targeted to the Staking platform type:refactor A code change that neither fixes a bug nor adds a feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove code related to the gas-based staking pools
3 participants
@dandheedge @brunomenezes @nevendyulgerov