Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#17 Optimize Unit Test for apps/rollups #21

Merged
merged 1 commit into from
Jun 26, 2023

Conversation

dandheedge
Copy link
Contributor

Summary

Optimizing the unit test on the apps/rollups

Before the changes, there are some warning on the graphql endpoint. Time to complete ~18s

Screenshot 2023-06-23 at 14 42 00

After the changes

Screenshot 2023-06-23 at 14 27 02

Related Issue(s)

Fixes #17

@dandheedge dandheedge added the type:refactor A code change that neither fixes a bug nor adds a feature label Jun 23, 2023
@dandheedge dandheedge self-assigned this Jun 23, 2023
@vercel
Copy link

vercel bot commented Jun 23, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
rollups ✅ Ready (Inspect) Visit Preview Jun 23, 2023 7:46am
staking ✅ Ready (Inspect) Visit Preview Jun 23, 2023 7:46am

@coveralls
Copy link

Pull Request Test Coverage Report for Build 5354070169

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.005%) to 72.546%

Totals Coverage Status
Change from base Build 5342173159: -0.005%
Covered Lines: 2592
Relevant Lines: 3402

💛 - Coveralls

Copy link
Collaborator

@brunomenezes brunomenezes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@brunomenezes brunomenezes merged commit b0e5373 into main Jun 26, 2023
4 of 5 checks passed
@brunomenezes brunomenezes deleted the refactor/17-optimize-unit-test-for-rollups branch June 26, 2023 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:refactor A code change that neither fixes a bug nor adds a feature
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Optimize unit tests for apps/rollups
3 participants