Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#18 Optimize unit tests for apps/staking #26

Merged
merged 1 commit into from
Jul 2, 2023
Merged

#18 Optimize unit tests for apps/staking #26

merged 1 commit into from
Jul 2, 2023

Conversation

nevendyulgerov
Copy link
Contributor

Optimized speed of unit tests for apps/staking by refactoring imports.

Before the changes:
Screenshot 2023-06-29 at 15 06 49

After the changes:
Screenshot 2023-06-29 at 16 37 43

@nevendyulgerov nevendyulgerov added type:refactor A code change that neither fixes a bug nor adds a feature staking Changes targeted to the Staking platform labels Jun 29, 2023
@nevendyulgerov nevendyulgerov self-assigned this Jun 29, 2023
@vercel
Copy link

vercel bot commented Jun 29, 2023 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rollups ✅ Ready (Inspect) Visit Preview Jun 29, 2023 2:55pm
staking ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 29, 2023 2:55pm

@nevendyulgerov nevendyulgerov linked an issue Jun 29, 2023 that may be closed by this pull request
Optimize unit tests for apps/staking #18
Closed
5 tasks
@nevendyulgerov nevendyulgerov changed the title #18 Optimize staking tests #18 Optimize unit tests for apps/staking Jun 29, 2023
@coveralls
Copy link

Pull Request Test Coverage Report for Build 5413676420

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 72.752%
Totals Coverage Status
Change from base Build 5372965490: 0.0%
Covered Lines: 2548
Relevant Lines: 3337
💛 - Coveralls

@brunomenezes brunomenezes merged commit 4c27bc9 into main Jul 2, 2023
4 checks passed
@brunomenezes brunomenezes deleted the test/18-optimize-staking-tests branch July 2, 2023 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brunomenezes brunomenezes brunomenezes approved these changes

@dandheedge dandheedge Awaiting requested review from dandheedge

Assignees

@nevendyulgerov nevendyulgerov

Labels
staking Changes targeted to the Staking platform type:refactor A code change that neither fixes a bug nor adds a feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Optimize unit tests for apps/staking
3 participants
@nevendyulgerov @coveralls @brunomenezes