Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#33 Update test related dependencies and fix console errors #34

Merged
merged 2 commits into from
Jul 6, 2023
Merged

#33 Update test related dependencies and fix console errors #34

merged 2 commits into from
Jul 6, 2023

Conversation

nevendyulgerov
Copy link
Contributor

@nevendyulgerov nevendyulgerov commented Jul 5, 2023 •
edited
Loading

This branch uses chore/31-bump-dependencies-for-ui-package as base branch.

In it, I updated test related dependencies for packages/ui and fixed several console errors for components not being wrapped in act.

@nevendyulgerov nevendyulgerov self-assigned this Jul 5, 2023
@vercel
Copy link

vercel bot commented Jul 5, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rollups ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 5, 2023 3:40pm
staking ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 5, 2023 3:40pm

@nevendyulgerov nevendyulgerov linked an issue Jul 5, 2023 that may be closed by this pull request
Update jest dependencies and fix console errors. #33
Closed
@nevendyulgerov nevendyulgerov changed the title #33 Update jest dependencies and fix console errors #33 Update test related dependencies and fix console errors Jul 5, 2023
@github-actions
Copy link

github-actions bot commented Jul 5, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 5466142437

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 72.752%
Totals Coverage Status
Change from base Build 5439112661: 0.0%
Covered Lines: 2548
Relevant Lines: 3337
💛 - Coveralls

@brunomenezes
Copy link
Collaborator

brunomenezes commented Jul 6, 2023 •
edited
Loading

@nevendyulgerov,
Do you want to merge that PR directly into main, or will you create a feature branch for #31 and merge against that? Just double checking before I merge the PR.

@nevendyulgerov
Copy link
Contributor Author

@nevendyulgerov, Do you want to merge that PR directly into main, or will you create a feature branch for #31 and merge against that? Just double checking before I merge the PR.

Hey @brunomenezes , I'll create a branch for #31 and merge this one in it.

@nevendyulgerov nevendyulgerov changed the base branch from main to chore/31-bump-dependencies-for-ui-package July 6, 2023 07:57
@nevendyulgerov nevendyulgerov merged commit 4ceca75 into chore/31-bump-dependencies-for-ui-package Jul 6, 2023
4 of 5 checks passed
@nevendyulgerov nevendyulgerov deleted the chore/33-update-jest-dependencies branch July 6, 2023 07:58
@nevendyulgerov nevendyulgerov mentioned this pull request Jul 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brunomenezes brunomenezes brunomenezes approved these changes

@dandheedge dandheedge Awaiting requested review from dandheedge

Assignees

@nevendyulgerov nevendyulgerov

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update jest dependencies and fix console errors.
2 participants
@nevendyulgerov @brunomenezes