Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replacing QEMU with Depot #39

Merged
merged 2 commits into from
Jul 11, 2023
Merged

Replacing QEMU with Depot #39

merged 2 commits into from
Jul 11, 2023

Conversation

brunomenezes
Copy link
Collaborator

@brunomenezes brunomenezes commented Jul 10, 2023 •
edited

Changes applied to the GitHub action that generates docker images for the Rollup Explorer app.

  1. Added integration with Depot.
  2. Add permission for issuing OIDC tokens for the workflow run.
  3. Removed QEMU setup step
  4. Removed docker/build-push-action step
  5. Added a docker-bake.hcl to describe a high-level build command.
  6. Also, added a bake-override in the workflow definition to avoid problems with working directory.

@brunomenezes brunomenezes linked an issue Jul 10, 2023 that may be closed by this pull request
Move rollups docker packaging from QEMU #35
Closed
6 tasks
@vercel
Copy link

vercel bot commented Jul 10, 2023 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rollups ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 10, 2023 5:47am
staking ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 10, 2023 5:47am

@brunomenezes brunomenezes force-pushed the feature/35-replace-qemu-with-depot branch from eb02b7c to 97de313 Compare July 10, 2023 05:02
@coveralls
Copy link

coveralls commented Jul 10, 2023 •
edited

Pull Request Test Coverage Report for Build 5504533399

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 73.126%
Totals Coverage Status
Change from base Build 5470092370: 0.0%
Covered Lines: 2544
Relevant Lines: 3315
💛 - Coveralls

@brunomenezes brunomenezes force-pushed the feature/35-replace-qemu-with-depot branch from 97de313 to 260a104 Compare July 10, 2023 05:46
@brunomenezes brunomenezes marked this pull request as ready for review July 10, 2023 05:48
@brunomenezes brunomenezes merged commit cb72e28 into main Jul 11, 2023
5 checks passed
@brunomenezes brunomenezes deleted the feature/35-replace-qemu-with-depot branch July 11, 2023 05:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nevendyulgerov nevendyulgerov nevendyulgerov approved these changes

@tuler tuler Awaiting requested review from tuler

@dandheedge dandheedge Awaiting requested review from dandheedge

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move rollups docker packaging from QEMU
3 participants
@brunomenezes @coveralls @nevendyulgerov