-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#3 Improve test coverage for apps/staking #4
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Pull Request Test Coverage Report for Build 5240077378
💛 - Coveralls |
486d729
to
e76051b
Compare
@nevendyulgerov ,
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @nevendyulgerov, Good clean-up along the way. However, food for thought here is that there is a bit of a "cheat" like the header links and footer links for the Layout component because if someone mistakenly removes a header link from the array, this test will still pass. It is like implementation detail leaking into the test and driving the expectation
making the test intention actually obscure. What are your thoughts?
Nonetheless, I will approve the PR.
Summary
This PR adds more unit tests for
apps/staking
with the goal to increase the test coverage to about75%
.