Fix: App navigation #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the analytics object from to the useEffect watch list that was causing a infinite loop. Therefore, affecting the nextJS routing system to take a long time to schedule its change since the main-thread was floaded.
Add information for next explorer release v3.5.2
brunomenezes
added
type:bug
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
tuler
approved these changes
Jul 17, 2023
Pull Request Test Coverage Report for Build 5576322396
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
A report was made that links in the headers were changing the address bar, but the app would not "display" the page itself. But the reality is that the links and buttons (usually calling the next router programmatically) would also not work. After checking the released tags, the problem was introduced on v3.5.0 after checking the changes between the tags, the cause was an item added in the
useEffectwatchlist causing an infinite loop in twouseEffecthooks inside the ga4Tracker.tsx here and here. The gist is that the main-thread was flooded with calls and nextJS router system was having a hard time to do its job.PS: That was flying under the radar because most of the people enter the App with their wallets automatically connected (including us 🫠), causing the useEffect to stop firing events as the
analyticswould be finally initialised.Before and After