Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#75 Fix storybooks #76

Merged
merged 2 commits into from
Aug 1, 2023
Merged

#75 Fix storybooks #76

merged 2 commits into from
Aug 1, 2023

Conversation

nevendyulgerov
Copy link
Contributor

Fix for staking storybook. The issue was due to custom hooks being invoked in storybook decorator, which after recent upgrade doesn't work anymore.

I also fixed the storybook packages/ui build, that was failing due to not transpiled library.

There is another runtime issue I noticed for packages/ui's storybook:

Uncaught Error: WalletConnect requires a projectId. Please visit https://cloud.walletconnect.com to get one.

Probably a wallet provider is missing in the storybook preview, but I haven't checked this further.

@nevendyulgerov nevendyulgerov added the type:bug Something isn't working and requires a fix label Aug 1, 2023
@nevendyulgerov nevendyulgerov self-assigned this Aug 1, 2023
@vercel
Copy link

vercel bot commented Aug 1, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rollups ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 1, 2023 6:33pm
staking ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 1, 2023 6:33pm

@coveralls
Copy link

coveralls commented Aug 1, 2023

Pull Request Test Coverage Report for Build 5730527509

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 73.16%

Totals Coverage Status
Change from base Build 5720796303: 0.0%
Covered Lines: 2568
Relevant Lines: 3345

💛 - Coveralls

@nevendyulgerov nevendyulgerov linked an issue Aug 1, 2023 that may be closed by this pull request
3 tasks
@nevendyulgerov nevendyulgerov marked this pull request as ready for review August 1, 2023 12:28
Copy link
Collaborator

@brunomenezes brunomenezes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @nevendyulgerov,
I pushed a commit to settle the WalletConnect exception message.

Currently, Chromatic is having some service degradation: https://status.chromatic.com/

So the publishing step is hanging, and I am cancelling the action to avoid burning the GitHub quota.

@brunomenezes brunomenezes merged commit 8409176 into main Aug 1, 2023
7 of 9 checks passed
@brunomenezes brunomenezes deleted the bugfix/75-fix-storybook branch August 1, 2023 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Something isn't working and requires a fix
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

yarn storybook command not working properly
3 participants