Remove ledger support as an individual option #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add information for next explorer release v3.6.1
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Pull Request Test Coverage Report for Build 5736000375
💛 - Coveralls |
|
I'll bypass the review, as there are already users being affected. cc: @tuler , @nevendyulgerov, @dandheedge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We just released the upgrade of multiple modules from web3-onboard given the emergency to move from WalletConnect v1.0 to v2.0. The Ledger module specifically is not working properly; after its selection and making the connection, a few pieces of information are displayed, but the main driver (ethers web3provider) is not being able to communicate with contracts, nor do a series of other actions making the functionalities from the Staking app unusable. The users can connect the ledger hardware wallet through the WalletConnect option. The new workflow is the same since the new version uses the Ledger Live App.
PS: I flicked a message in the blocknative discord and have a branch here that has modifications and the ledger still available. So depending on how they respond, we may bring it back. In the meantime, I think removing the standalone option is best to avoid confusion.