Validate uarch instruction set after build #108
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpernambuco
force-pushed
the
validate-uarch-instruction-set-after-build
branch
from
a2a7d41
to
8917b8f
Compare
diegonehab
previously approved these changes
Jul 19, 2023
edubart
requested changes
Jul 20, 2023
mpernambuco
force-pushed
the
validate-uarch-instruction-set-after-build
branch
2 times, most recently
from
9d1f7f9
to
9d87509
Compare
edubart
approved these changes
Jul 20, 2023
mpernambuco
force-pushed
the
validate-uarch-instruction-set-after-build
branch
from
9d87509
to
f2c3e48
Compare
|
I think we can merge this @vfusco |
|
wont need this anymore. See #195 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch adds a simple validation step to the microarchitecture Makefile.
It checks if all instructions in
uarch-ram.elfbelong to the supported instruction set.The motivation is to make it easier to test other toolchains and be alerted if it generates unsupported instructions.