Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: remove withdrawERC20Tokens function #163

Merged
merged 1 commit into from
Dec 4, 2023

Conversation

guidanoli
Copy link
Collaborator

Closes #162

@guidanoli guidanoli force-pushed the feature/erc20less-authority branch 2 times, most recently from 0307ffe to 648e39a Compare December 1, 2023 02:58
@guidanoli guidanoli force-pushed the feature/erc20less-authority branch from 648e39a to 1816884 Compare December 2, 2023 13:41
@guidanoli guidanoli force-pushed the feature/erc20less-authority branch from 1816884 to 1ccf3ec Compare December 2, 2023 13:47
@guidanoli guidanoli requested a review from ZzzzHui December 4, 2023 02:02
Copy link
Contributor

@ZzzzHui ZzzzHui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should there be 2 changeset files for 1 commit?

@guidanoli
Copy link
Collaborator Author

Should there be 2 changeset files for 1 commit?

It's because these are different changes. One is about the function and the other is about the error. I could have put them into the same changeset file too.

@guidanoli guidanoli merged commit e2bc71c into main Dec 4, 2023
3 checks passed
@guidanoli guidanoli deleted the feature/erc20less-authority branch December 4, 2023 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove ERC-20 entry points from consensus contract(s)
3 participants