Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Some refactoring was done to the logic handling the erc-20 deposit, previously done by a public method called
handlePayload()
. After adding code for erc-721 deposits, the idea is to have the same method naming to deal with its own piece of logic. Also, method visibility was applied, so eachprepare*()
is private, so tests should only be done through thehandle()
method and then expectations are checked.Changelog:
prepareErc20Deposit()
, including its storage setting and related logging.handlePayload()
method.prepare*()
methods as aconst
tuple and use spread to pass down to each method.prepare*
method visibility to private.handlePayload()
.