Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: cached parseAbi inputs/outputs #277

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

brunomenezes
Copy link
Collaborator

@brunomenezes brunomenezes commented Dec 10, 2024

Summary

The upgrade will fix a problem caused by caching logic inside the abitype library. An issue was raised explaining the case, and they fixed and released it. More details are in the issue link below. Also, a standalone abitype dependency was removed and all imports and usage replaced by viem. Text fixes were also applied.

Issue: wevm/abitype#247
Release: abitype/releases@1.0.7

Copy link

vercel bot commented Dec 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rollups-explorer-arbitrum-mainnet ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 10, 2024 11:38pm
rollups-explorer-arbitrum-sepolia ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 10, 2024 11:38pm
rollups-explorer-base-mainnet ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 10, 2024 11:38pm
rollups-explorer-base-sepolia ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 10, 2024 11:38pm
rollups-explorer-mainnet ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 10, 2024 11:38pm
rollups-explorer-optimism-mainnet ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 10, 2024 11:38pm
rollups-explorer-optimism-sepolia ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 10, 2024 11:38pm
rollups-explorer-sepolia ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 10, 2024 11:38pm
rollups-explorer-workshop ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 10, 2024 11:38pm

Copy link
Contributor

@nevendyulgerov nevendyulgerov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one, @brunomenezes , I noticed the same issue while I was developing the generic input form. Big ups for bringing this to the attention of the viem's team.

@brunomenezes brunomenezes merged commit ec9cba8 into main Dec 11, 2024
22 of 23 checks passed
@brunomenezes brunomenezes deleted the fix/parse-abi-cached-inputs-ouputs branch December 11, 2024 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants