Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#286 Add e2e tests for specifications pages #298

Merged
merged 3 commits into from
Jan 21, 2025

Conversation

nevendyulgerov
Copy link
Contributor

I added e2e tests for:

  • /specifications page
  • /specifications/new page
  • /specifications/edit page

One of those tests caught an issue for the ABI Parameters that I logged here.

@nevendyulgerov nevendyulgerov self-assigned this Jan 13, 2025
Copy link

vercel bot commented Jan 13, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rollups-explorer-arbitrum-mainnet ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 21, 2025 4:47pm
rollups-explorer-arbitrum-sepolia ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 21, 2025 4:47pm
rollups-explorer-base-mainnet ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 21, 2025 4:47pm
rollups-explorer-base-sepolia ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 21, 2025 4:47pm
rollups-explorer-mainnet ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 21, 2025 4:47pm
rollups-explorer-optimism-mainnet ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 21, 2025 4:47pm
rollups-explorer-optimism-sepolia ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 21, 2025 4:47pm
rollups-explorer-sepolia ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 21, 2025 4:47pm
rollups-explorer-workshop ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 21, 2025 4:47pm

@nevendyulgerov nevendyulgerov linked an issue Jan 13, 2025 that may be closed by this pull request
2 tasks
@nevendyulgerov nevendyulgerov marked this pull request as ready for review January 13, 2025 13:47
@brunomenezes
Copy link
Collaborator

@nevendyulgerov, a rebase is necessary, and the end-to-end is red at the moment.

@brunomenezes brunomenezes merged commit d606826 into main Jan 21, 2025
24 checks passed
@brunomenezes brunomenezes deleted the tests/286-add-e2e-tests-for-specifications-pages branch January 21, 2025 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cover specs page with e2e tests
2 participants