Deploy to base

[tuler]

Deploy contracts to base network.

[coveralls]

Pull Request Test Coverage Report for Build 8631128767

Details

• 0 of 0 changed or added relevant lines in 0 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage remained the same at 94.24%

---

Totals
Change from base Build 7214077584:	0.0%
Covered Lines:	274
Relevant Lines:	290

---

💛 - Coveralls

[guidanoli]

The pnpm run prettier command on packages/contracts is not working.

No parser could be inferred for file "...".

Adding the following line to the .prettierrc.json file seems to fix the problem.

diff --git a/packages/contracts/.prettierrc.json b/packages/contracts/.prettierrc.json
index 100e63c..cca0824 100644
--- a/packages/contracts/.prettierrc.json
+++ b/packages/contracts/.prettierrc.json
@@ -1,5 +1,6 @@
 {
     "tabWidth": 4,
+    "plugins": ["prettier-plugin-solidity"],
     "overrides": [
         {
             "files": "*.sol",

[guidanoli]

I was not able to figure out the tsc error when we migrated from yarn to pnpm though...

[guidanoli]

Setting skipLibCheck to true on tsconfig.json worked, but I'm not sure whether it's safe to go down this path.

[tuler]

skipLibCheck

I think it's a fair compromise for now.

[guidanoli]

It appears that even big projects that depend on viem@^2 such as OneKey use this configuration.

[guidanoli]

There are references to Yarn in the README

[tuler]

It appears that even big projects that depend on viem@^2 such as OneKey use this configuration.

It should definitely not be needed, but I would't worry in this case

[guidanoli]

It should definitely not be needed, but I would worry in this case

I agree. I wonder, though, if this issue can be fixed later.

[guidanoli]

Optionally, I would sort the entries in the tsconfig.json.