Add support for protected(set) and public(set)
#25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Huh! i was not even aware that those modifiers were supported! Thank you for your contribution! :D |
ryangjchandler
force-pushed
the
protected-public-set
branch
from
c0c1d71 to
940b457
Compare
|
Commit is saying unverified, but I've definitely got a GPG key setup 🫠 |
azjezz
reviewed
Dec 11, 2024
crates/linter/src/plugin/redundancy/rules/redundant_write_visibility.rs
Outdated
Show resolved
Hide resolved
crates/linter/src/plugin/redundancy/rules/redundant_write_visibility.rs
Outdated
Show resolved
Hide resolved
crates/linter/src/plugin/redundancy/rules/redundant_write_visibility.rs
Outdated
Show resolved
Hide resolved
ryangjchandler
force-pushed
the
protected-public-set
branch
2 times, most recently
from
7c4f862 to
89a29b5
Compare
azjezz
force-pushed
the
main
branch
8 times, most recently
from
763610e to
b9aa4b7
Compare
azjezz
force-pushed
the
protected-public-set
branch
from
89a29b5 to
c805b83
Compare
Signed-off-by: azjezz <azjezz@protonmail.com>
azjezz
force-pushed
the
protected-public-set
branch
from
c805b83 to
62acd1f
Compare
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
protected(set)andpublic(set)are semantically valid.public public(set)is silly but valid PHP code. PHP doesn't warn or error because of the identical visibilities.I've added a new linter rule to tell you that the additional write visibility is redundant too:
Side note - I've marked the fix as potentially unsafe since there could be a reason for having identical read/write visibilities, but also happy to change that to a safe fix since it doesn't really have an effect.