Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to set labels on image push #412

Closed

Conversation

old-ocean-creature
Copy link

Add ability to set labels on image push

@vmwclabot
Copy link

@old-ocean-creature, you must sign our contributor license agreement before your changes are merged. Click here to sign the agreement. If you are a VMware employee, read this for further instruction.

@old-ocean-creature
Copy link
Author

fixes #153

Copy link
Member

@joaopapereira joaopapereira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey
Thanks for putting together this PR.
Looks like some tests are failing, do you mind taking a look to see what is happening.

Also not sure if it would make more sense for it to be called --label singular since you would have to provide the --label flag per label you want to add.
Another nice to have is for this to be provided with the ability to add labels to the bundles as well.
And to top it off, if you could also add some tests to ensure that the labels are being added correctly that would be awesome.

Let me know if you need help with any of the above comments

@vmwclabot
Copy link

@old-ocean-creature, VMware has approved your signed contributor license agreement.

@renuy renuy linked an issue Jul 11, 2023 that may be closed by this pull request
@phenixblue
Copy link
Contributor

@joaopapereira I believe this can be closed now since #552 was merged

@joaopapereira
Copy link
Member

Closing since the work was already done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add annotations/labels to bundle
4 participants