-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for OCI labels on image/bundle push #552
Merged
joaopapereira
merged 9 commits into
carvel-dev:develop
from
phenixblue:add-labels-for-bundles-and-images
Aug 3, 2023
Merged
Add support for OCI labels on image/bundle push #552
joaopapereira
merged 9 commits into
carvel-dev:develop
from
phenixblue:add-labels-for-bundles-and-images
Aug 3, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phenixblue
had a problem deploying
to
TanzuNet Registry Dev e2e
July 26, 2023 19:54 — with
GitHub Actions
Failure
Signed-off-by: Joe Searcy <joe@twr.io>
Signed-off-by: Joe Searcy <joe@twr.io>
phenixblue
force-pushed
the
add-labels-for-bundles-and-images
branch
from
July 26, 2023 19:57
00e3d96
to
63e8348
Compare
phenixblue
had a problem deploying
to
TanzuNet Registry Dev e2e
July 26, 2023 19:57 — with
GitHub Actions
Failure
phenixblue
had a problem deploying
to
TanzuNet Registry Dev e2e
July 26, 2023 20:00 — with
GitHub Actions
Failure
Related to #412 |
Signed-off-by: Joe Searcy <joe@twr.io>
phenixblue
temporarily deployed
to
TanzuNet Registry Dev e2e
July 30, 2023 06:46 — with
GitHub Actions
Inactive
Signed-off-by: Joe Searcy <joe@twr.io>
Signed-off-by: Joe Searcy <joe@twr.io>
phenixblue
temporarily deployed
to
TanzuNet Registry Dev e2e
August 1, 2023 21:34 — with
GitHub Actions
Inactive
joaopapereira
requested changes
Aug 2, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change looks good to me. Added some questions and suggestions.
phenixblue
temporarily deployed
to
TanzuNet Registry Dev e2e
August 2, 2023 17:32 — with
GitHub Actions
Inactive
phenixblue
had a problem deploying
to
TanzuNet Registry Dev e2e
August 2, 2023 18:34 — with
GitHub Actions
Failure
Co-authored-by: João Pereira <joaopapereira@gmail.com> Signed-off-by: Joe Searcy <joe@twr.io>
Signed-off-by: Joe Searcy <joe@twr.io>
Signed-off-by: Joe Searcy <joe@twr.io>
phenixblue
force-pushed
the
add-labels-for-bundles-and-images
branch
from
August 2, 2023 18:41
4ff82e7
to
f5d15ff
Compare
phenixblue
temporarily deployed
to
TanzuNet Registry Dev e2e
August 2, 2023 18:41 — with
GitHub Actions
Inactive
Signed-off-by: Joe Searcy <joe@twr.io>
phenixblue
had a problem deploying
to
TanzuNet Registry Dev e2e
August 2, 2023 19:12 — with
GitHub Actions
Failure
phenixblue
temporarily deployed
to
TanzuNet Registry Dev e2e
August 2, 2023 20:43 — with
GitHub Actions
Inactive
joaopapereira
approved these changes
Aug 3, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the ability for users to specify OCI labels that will be added to the generated OCI artifact (bundle/image) during a
push
operation.Fixes #153
Example:
The resulting OCI artifact can be inspected as such to show the labels added: