Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with bundles multiple repos #508

Merged
merged 8 commits into from
Apr 18, 2023

Conversation

joaopapereira
Copy link
Member

@joaopapereira joaopapereira commented Mar 31, 2023

In this PR we now funnel all the requests through the same function that will calculate the Bundle Graph. This required quite some changes but at the same time allowed us to do some improvements in readability of the code

Fixes #499

Signed-off-by: Joao Pereira <joaod@vmware.com>
Signed-off-by: Joao Pereira <joaod@vmware.com>
@joaopapereira joaopapereira temporarily deployed to TanzuNet Registry Dev e2e March 31, 2023 19:32 — with GitHub Actions Inactive
@joaopapereira joaopapereira temporarily deployed to GCR e2e March 31, 2023 19:32 — with GitHub Actions Inactive
Signed-off-by: Joao Pereira <joaod@vmware.com>
It can read the bundle graph from the registry or from preprocessed
images

Signed-off-by: Joao Pereira <joaod@vmware.com>
@joaopapereira joaopapereira force-pushed the issue-with-bundles-multiple-repos branch from fbc3a44 to d23bd11 Compare April 4, 2023 21:20
@joaopapereira joaopapereira temporarily deployed to TanzuNet Registry Dev e2e April 4, 2023 21:20 — with GitHub Actions Inactive
@joaopapereira joaopapereira temporarily deployed to GCR e2e April 4, 2023 21:20 — with GitHub Actions Inactive
- Fix race conditions
- Refactor some tests

Signed-off-by: Joao Pereira <joaod@vmware.com>
@joaopapereira joaopapereira temporarily deployed to GCR e2e April 5, 2023 21:30 — with GitHub Actions Inactive
@joaopapereira joaopapereira temporarily deployed to TanzuNet Registry Dev e2e April 5, 2023 21:30 — with GitHub Actions Inactive
@joaopapereira joaopapereira marked this pull request as ready for review April 5, 2023 21:32
@joaopapereira joaopapereira had a problem deploying to TanzuNet Registry Dev e2e April 5, 2023 21:35 — with GitHub Actions Failure
@joaopapereira joaopapereira force-pushed the issue-with-bundles-multiple-repos branch from 3a37268 to 85aa0a7 Compare April 10, 2023 19:10
@joaopapereira joaopapereira temporarily deployed to TanzuNet Registry Dev e2e April 10, 2023 19:10 — with GitHub Actions Inactive
@joaopapereira joaopapereira temporarily deployed to GCR e2e April 10, 2023 19:10 — with GitHub Actions Inactive
pkg/imgpkg/bundle/bundle.go Outdated Show resolved Hide resolved
pkg/imgpkg/bundle/bundle.go Outdated Show resolved Hide resolved
pkg/imgpkg/internal/util/lock_with_key.go Outdated Show resolved Hide resolved
Ensure that when fetching a particular bundle there are no 2 concurrent
requests for it, while allowing the other requests to continue for
different bundles

Signed-off-by: Joao Pereira <joaod@vmware.com>
@joaopapereira joaopapereira force-pushed the issue-with-bundles-multiple-repos branch from 85aa0a7 to 2fcd2ed Compare April 12, 2023 16:15
@joaopapereira joaopapereira temporarily deployed to GCR e2e April 12, 2023 16:15 — with GitHub Actions Inactive
@joaopapereira joaopapereira temporarily deployed to TanzuNet Registry Dev e2e April 12, 2023 16:15 — with GitHub Actions Inactive
@joaopapereira joaopapereira temporarily deployed to TanzuNet Registry Dev e2e April 12, 2023 22:06 — with GitHub Actions Inactive
@joaopapereira joaopapereira temporarily deployed to GCR e2e April 12, 2023 22:06 — with GitHub Actions Inactive
Signed-off-by: Joao Pereira <joaod@vmware.com>
@joaopapereira joaopapereira force-pushed the issue-with-bundles-multiple-repos branch from 66e61b6 to 1bb4e3a Compare April 12, 2023 22:10
@joaopapereira joaopapereira temporarily deployed to GCR e2e April 12, 2023 22:10 — with GitHub Actions Inactive
@joaopapereira joaopapereira temporarily deployed to TanzuNet Registry Dev e2e April 12, 2023 22:10 — with GitHub Actions Inactive
Signed-off-by: Joao Pereira <joaod@vmware.com>
@joaopapereira joaopapereira temporarily deployed to GCR e2e April 18, 2023 19:00 — with GitHub Actions Inactive
@joaopapereira joaopapereira temporarily deployed to TanzuNet Registry Dev e2e April 18, 2023 19:00 — with GitHub Actions Inactive
@joaopapereira joaopapereira merged commit 9403390 into develop Apr 18, 2023
@joaopapereira joaopapereira deleted the issue-with-bundles-multiple-repos branch April 18, 2023 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Copy to tar and back to repository doesn't always work
2 participants