-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue with bundles multiple repos #508
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joao Pereira <joaod@vmware.com>
Signed-off-by: Joao Pereira <joaod@vmware.com>
joaopapereira
temporarily deployed
to
TanzuNet Registry Dev e2e
March 31, 2023 19:32
— with
GitHub Actions
Inactive
Signed-off-by: Joao Pereira <joaod@vmware.com>
It can read the bundle graph from the registry or from preprocessed images Signed-off-by: Joao Pereira <joaod@vmware.com>
joaopapereira
force-pushed
the
issue-with-bundles-multiple-repos
branch
from
April 4, 2023 21:20
fbc3a44
to
d23bd11
Compare
joaopapereira
temporarily deployed
to
TanzuNet Registry Dev e2e
April 4, 2023 21:20
— with
GitHub Actions
Inactive
- Fix race conditions - Refactor some tests Signed-off-by: Joao Pereira <joaod@vmware.com>
joaopapereira
temporarily deployed
to
TanzuNet Registry Dev e2e
April 5, 2023 21:30
— with
GitHub Actions
Inactive
joaopapereira
had a problem deploying
to
TanzuNet Registry Dev e2e
April 5, 2023 21:35
— with
GitHub Actions
Failure
joaopapereira
force-pushed
the
issue-with-bundles-multiple-repos
branch
from
April 10, 2023 19:10
3a37268
to
85aa0a7
Compare
joaopapereira
temporarily deployed
to
TanzuNet Registry Dev e2e
April 10, 2023 19:10
— with
GitHub Actions
Inactive
cppforlife
reviewed
Apr 11, 2023
Ensure that when fetching a particular bundle there are no 2 concurrent requests for it, while allowing the other requests to continue for different bundles Signed-off-by: Joao Pereira <joaod@vmware.com>
joaopapereira
force-pushed
the
issue-with-bundles-multiple-repos
branch
from
April 12, 2023 16:15
85aa0a7
to
2fcd2ed
Compare
joaopapereira
temporarily deployed
to
TanzuNet Registry Dev e2e
April 12, 2023 16:15
— with
GitHub Actions
Inactive
joaopapereira
temporarily deployed
to
TanzuNet Registry Dev e2e
April 12, 2023 22:06
— with
GitHub Actions
Inactive
Signed-off-by: Joao Pereira <joaod@vmware.com>
joaopapereira
force-pushed
the
issue-with-bundles-multiple-repos
branch
from
April 12, 2023 22:10
66e61b6
to
1bb4e3a
Compare
joaopapereira
temporarily deployed
to
TanzuNet Registry Dev e2e
April 12, 2023 22:10
— with
GitHub Actions
Inactive
Signed-off-by: Joao Pereira <joaod@vmware.com>
joaopapereira
temporarily deployed
to
TanzuNet Registry Dev e2e
April 18, 2023 19:00
— with
GitHub Actions
Inactive
cppforlife
approved these changes
Apr 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR we now funnel all the requests through the same function that will calculate the Bundle Graph. This required quite some changes but at the same time allowed us to do some improvements in readability of the code
Fixes #499