-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CRD Upgrade Safety preflight check #901
Add CRD Upgrade Safety preflight check #901
Conversation
Note: I'm planning to squash commits prior to merging, but after reviews have been done to keep it easier to review |
dc3799e
to
a42be1a
Compare
Whelp a botched rebase caused some problems that ended up in me deciding a squash after the rebase would be cleaner than the individual commits. Apologies to the reviewers! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you so much for making kapp better ❤️
I think a rebase would be required as Todd's PR is merged.
and some initial validations for handling scope changes and removal of existing stored versions Signed-off-by: everettraven <everettraven@gmail.com>
6fbc4ef
to
e12d91d
Compare
Thanks @praveenrewar ! I've just rebased, updated, and squashed the commits. Should be ready to merge! The update made was https://github.com/carvel-dev/kapp/pull/901/files#diff-02d1be65fcbbdbd73025e5327506d584006201a288ba1c598b92e7d67467529eR52-R54 to satisfy the change to the |
What this PR does / why we need it:
Adds an initial implementation of carvel-dev/carvel#729
Includes the new
CRDUpgradeSafety
preflight check implementation and 2 of the known breaking changes during a CRD upgrade:Implementation is broken down into individual commits for review purposes, I am happy to squash commits before merging:
Which issue(s) this PR fixes:
Fixes #909
Does this PR introduce a user-facing change?
Additional Notes for your reviewer:
Review Checklist:
a link to that PR
change
Additional documentation e.g., Proposal, usage docs, etc.: