-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add handling of updates to a field's enum values to the CRD Upgrade Safety preflight check #921
Add handling of updates to a field's enum values to the CRD Upgrade Safety preflight check #921
Conversation
Note: I'll squash commits after reviews |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty good apart from some minor comments.
I also wanted to mention one additional thing apart from the comments. In the Carvel world, we have been capitalising error strings (examples can be found across the projects). I know, I know, this is not as per the go style decisions, however since this is being done across the carvel tool suite, the error messages are consistent within Carvel. This might be something worth discussing outside the scope of this PR (maybe in the community meeting?). At this point I don't want to force you to capitalise error strings as even now when we get errors from some other library, they are not capitalised and the error messages are a mix of the two, which would be something similar with preflight checks.
test/e2e/preflight_crdupgradesafety_invalid_field_change_enums_added_test.go
Outdated
Show resolved
Hide resolved
b192141
to
ce52021
Compare
Signed-off-by: everettraven <everettraven@gmail.com>
ce52021
to
a1da50a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good to me!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!!
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #916
Does this PR introduce a user-facing change?
Additional Notes for your reviewer:
Review Checklist:
a link to that PR
change
Additional documentation e.g., Proposal, usage docs, etc.: