-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docker API Rate Limit #456
Comments
Reading the Dockerhub API rate limiting doc, it seems that two GET requests count as a pull. Does KBLD use a HEAD instead which is not rate limited? |
By default, kbld uses GET, not HEAD. kbld could eventually be enhanced to support some Environment variable that would do this for you. |
I've raised a pull request to change the method from GET to HEAD. I've tested and can see the DockerHub |
@joaopapereira do you think someone could review my pull request? We will struggle to adopt kbld with the current implementation draining the dockerhub rate limit. |
Sorry for the delay but I was out for a couple of days, I left a review in the PR |
Does anyone know if the KBLD queries count towards the Docker API rate limit? It does seem to.
Which brings me to my next question, does KBLD have a way to use a registry mirror? We have registry mirrors set up in our Docker daemon config to avoid hitting rate limits when pulling images and in order to use KBLD - we would need a way to make KBLD use/respect configured registry mirrors.
The text was updated successfully, but these errors were encountered: