Change registry query from GET to HEAD to avoid Dockerhub API rate li… #457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
antwacky
force-pushed
the
use-head-to-query-registry
branch
from
cb2baa3
to
6447c1e
Compare
antwacky
had a problem deploying
to
DockerHub E2E
GitHub Actions
Failure
joaopapereira
requested changes
Feb 20, 2024
There was a problem hiding this comment.
Unfortunately, it needs to be a little bit more complicated than that. Some registries do not like when you send Head requests in some situations, so in order to ensure that these still work we need to adopt the same logic we currently have in imgpkg
antwacky
force-pushed
the
use-head-to-query-registry
branch
4 times, most recently
from
67d5105
to
1464396
Compare
Signed-off-by: sethiyash <yashsethiya97@gmail.com>
Bumps [golang.org/x/net](https://github.com/golang/net) from 0.14.0 to 0.17.0. - [Commits](golang/net@v0.14.0...v0.17.0) --- updated-dependencies: - dependency-name: golang.org/x/net dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Praveen Rewar <8457124+praveenrewar@users.noreply.github.com>
Signed-off-by: sethiyash <yashsethiya97@gmail.com>
Signed-off-by: sethiyash <yashsethiya97@gmail.com>
Signed-off-by: Prashant Rewar <108176843+prashantrewar@users.noreply.github.com>
Signed-off-by: Yash Sethiya <ysethiya@ysethiya4MD6M.vmware.com>
Signed-off-by: Yash Sethiya <ysethiya@ysethiya4MD6M.vmware.com>
Signed-off-by: guoguangwu <guoguangwu@magic-shield.com>
antwacky
force-pushed
the
use-head-to-query-registry
branch
from
f600b72
to
d031e56
Compare
…falling back to a GET in case of error Signed-off-by: antwacky <pagey101@hotmail.co.uk>
antwacky
force-pushed
the
use-head-to-query-registry
branch
from
d031e56
to
2607529
Compare
|
Ah thanks for the pointer, I've updated to use HEAD in the first instance and fall back to GET in case of error as pointed out in the imgpkg library. |
antwacky
temporarily deployed
to
DockerHub E2E
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…mits