-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change registry query from GET to HEAD to avoid Dockerhub API rate li… #457
Change registry query from GET to HEAD to avoid Dockerhub API rate li… #457
Conversation
cb2baa3
to
6447c1e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately, it needs to be a little bit more complicated than that. Some registries do not like when you send Head requests in some situations, so in order to ensure that these still work we need to adopt the same logic we currently have in imgpkg
67d5105
to
1464396
Compare
Signed-off-by: sethiyash <yashsethiya97@gmail.com>
Bumps [golang.org/x/net](https://github.com/golang/net) from 0.14.0 to 0.17.0. - [Commits](golang/net@v0.14.0...v0.17.0) --- updated-dependencies: - dependency-name: golang.org/x/net dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Praveen Rewar <8457124+praveenrewar@users.noreply.github.com>
Signed-off-by: sethiyash <yashsethiya97@gmail.com>
Signed-off-by: sethiyash <yashsethiya97@gmail.com>
Signed-off-by: Prashant Rewar <108176843+prashantrewar@users.noreply.github.com>
Signed-off-by: Yash Sethiya <ysethiya@ysethiya4MD6M.vmware.com>
Signed-off-by: Yash Sethiya <ysethiya@ysethiya4MD6M.vmware.com>
Signed-off-by: guoguangwu <guoguangwu@magic-shield.com>
f600b72
to
d031e56
Compare
…falling back to a GET in case of error Signed-off-by: antwacky <pagey101@hotmail.co.uk>
d031e56
to
2607529
Compare
Ah thanks for the pointer, I've updated to use HEAD in the first instance and fall back to GET in case of error as pointed out in the imgpkg library. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…mits