Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove refs to deprecated io/ioutil #411

Merged
merged 1 commit into from
Feb 13, 2024
Merged

chore: remove refs to deprecated io/ioutil #411

merged 1 commit into from
Feb 13, 2024

Conversation

testwill
Copy link
Contributor

No description provided.

@testwill
chore: remove refs to deprecated io/ioutil
80ee4e2 
Signed-off-by: guoguangwu <guoguangwu@magic-shield.com>
@testwill testwill temporarily deployed to DockerHub E2E September 13, 2023 10:35 — with GitHub Actions Inactive
@sethiyash
Copy link
Contributor

sethiyash commented Sep 13, 2023 •
edited

Hi @testwill,
Thanks for raising this PR. This makes total sense to remove io/ioutil as it is deprecated as of Go 1.16.

joaopapereira
joaopapereira approved these changes Feb 13, 2024
View reviewed changes
Copy link
Member

@joaopapereira joaopapereira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joaopapereira joaopapereira merged commit 42fe6e3 into carvel-dev:develop Feb 13, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joaopapereira joaopapereira joaopapereira approved these changes

@sethiyash sethiyash sethiyash approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Carvel
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@testwill @sethiyash @joaopapereira