Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the module name #440

Merged
merged 1 commit into from
Feb 22, 2024
Merged

Update the module name #440

merged 1 commit into from
Feb 22, 2024

Conversation

prashantrewar
Copy link
Contributor

Fixes #430

@prashantrewar prashantrewar force-pushed the change-go-module-name branch 2 times, most recently from e2b8d4f to 3c0b325 Compare November 20, 2023 08:56
@joaopapereira
Copy link
Member

Sorry for the late reply do you mind rebasing this PR?

@prashantrewar
Update module name to carvel.dev
6e87eb3 
Signed-off-by: Prashant Rewar <108176843+prashantrewar@users.noreply.github.com>
@prashantrewar
Copy link
Contributor Author

@joaopapereira Done!

joaopapereira
joaopapereira approved these changes Feb 22, 2024
View reviewed changes
Copy link
Member

@joaopapereira joaopapereira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joaopapereira joaopapereira merged commit c7d6589 into carvel-dev:develop Feb 22, 2024
4 checks passed
@prashantrewar prashantrewar deleted the change-go-module-name branch February 23, 2024 04:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joaopapereira joaopapereira joaopapereira approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Carvel
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use vanity urls to change the go module name
2 participants
@prashantrewar @joaopapereira