Skip processing plain YAML files marked as template #324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pivotaljohn
force-pushed
the
detect-template
branch
2 times, most recently
from
0f913e9 to
9005c28
Compare
cppforlife
reviewed
Mar 15, 2021
pivotaljohn
force-pushed
the
detect-template
branch
from
9005c28 to
a6e8712
Compare
pivotaljohn
changed the title
cppforlife
reviewed
Mar 16, 2021
cppforlife
reviewed
Mar 16, 2021
cppforlife
reviewed
Mar 16, 2021
cppforlife
reviewed
Mar 16, 2021
- make DocExtractor insensitive to "unknown comments", simplifying its usage - rename yamltemplate.IsTemplate() to yamltemplate.HasTemplating(); the increase in precision is not only more accurate, but adds a touch of clarity to its usage.
cppforlife
reviewed
Mar 17, 2021
cppforlife
reviewed
Mar 17, 2021
- when we get serious calls for performance needs, we can optimize for reducing the number of mallocs. Until then, having a package-level variable for a constant like this isn't worth it.
pivotaljohn
added a commit
that referenced
this pull request
Mar 20, 2021
This reverts commit 553ef49.
This was referenced Apr 19, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses issue #232.