-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Export named validations to openApi properties #899
Export named validations to openApi properties #899
Conversation
Signed-off-by: Mathias Petermann <mathias.petermann@gmail.com>
will try to review this week. |
Just saw the linting errors, and will look into them. Should I squash my commits and force push, or is it fine to have mutliple commits, and the will be squashed when merged? |
b9e092c
to
65e9b19
Compare
you can have multiple commits and then squash them before merging. |
Any change to get a review on this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added some nitpick changes more stylistic than anything.
Generally, the PR looks good.
Signed-off-by: Mathias Petermann <mathias.petermann@gmail.com>
65e9b19
to
7348f37
Compare
Ammended whitespace cleanup into latest commit, and force pushed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This pull requests, exposes the attributes for the named
#@schema/validations
to the openApi schema, where a direct mapping is possible.The PR includes tests for all those validations.
Fixes #897