Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor openapi validation gen to avoid mutation inside GetValueType() #904

Merged
merged 4 commits into from
Apr 15, 2024
Merged

Refactor openapi validation gen to avoid mutation inside GetValueType() #904

merged 4 commits into from
Apr 15, 2024

Conversation

cppforlife
Copy link
Contributor

@cppforlife cppforlife commented Apr 13, 2024 •
edited
Loading

Also includes:

  • do not include named validation in openapi if when= is present
  • set min/maxItems and min/maxProperties when generating openapi for min/maxLen annotations

cc @peschmae @joaopapereira

Dmitriy Kalinin added 2 commits April 13, 2024 09:15
refact openapi validation gen to avoid mutation inside GetValueType()
6a30986 
Signed-off-by: Dmitriy Kalinin <dkalinin@vmware.com>
do not include named validation in openapi if when= is present
eacb7bc 
when= introduces more validation dynamicism which is not possible to represent via openapi

Signed-off-by: Dmitriy Kalinin <dkalinin@vmware.com>
Dmitriy Kalinin added 2 commits April 14, 2024 08:02
set min/maxItems and min/maxProperties when generating openapi
43dee5f 
Signed-off-by: Dmitriy Kalinin <dkalinin@vmware.com>
scope openapi methods to OpenAPIDocument
9663687 
Signed-off-by: Dmitriy Kalinin <dkalinin@vmware.com>
joaopapereira
joaopapereira approved these changes Apr 15, 2024
View reviewed changes
Copy link
Member

@joaopapereira joaopapereira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joaopapereira joaopapereira merged commit 2e686ef into develop Apr 15, 2024
5 checks passed
@joaopapereira joaopapereira deleted the dk-ytt-openapi branch April 15, 2024 14:38
@cppforlife cppforlife mentioned this pull request Apr 15, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joaopapereira joaopapereira joaopapereira approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Carvel
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cppforlife @joaopapereira