Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add '---' separator not after last item. #916

Merged
merged 1 commit into from
Sep 20, 2024

Conversation

ernstvonoelsen
Copy link
Contributor

targets resolution of #911

Signed-off-by: Ernst von Oelsen <ernst.vonoelsen@tngtech.com>
@100mik 100mik self-assigned this Jul 24, 2024
@renuy renuy requested a review from cppforlife July 24, 2024 15:28
@renuy
Copy link

renuy commented Jul 24, 2024

@cppforlife please review

@prnvbn
Copy link

prnvbn commented Aug 30, 2024

thank you for fixing this!

Copy link
Contributor

@prembhaskal prembhaskal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@cppforlife cppforlife merged commit 9ac89ff into carvel-dev:develop Sep 20, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

6 participants