Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup with the use of context managers #4

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Cleanup with the use of context managers #4

wants to merge 1 commit into from

Conversation

UP929312
Copy link

@UP929312 UP929312 commented Jun 9, 2022

This pull request uses context managers to cleanup the outdated open, read/write, close and should be used instead.
It also forces a flush, so that is also not needed.

Bertik23
Bertik23 approved these changes Jun 9, 2022
View reviewed changes
Copy link

@Bertik23 Bertik23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All fine.

CoolCat467
CoolCat467 suggested changes Jun 11, 2022
View reviewed changes
Copy link

@CoolCat467 CoolCat467 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

f is not a very pythonic name, I would suggest using something like file instead, but otherwise great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CoolCat467 CoolCat467 CoolCat467 requested changes

@Bertik23 Bertik23 Bertik23 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@UP929312 @Bertik23 @CoolCat467