Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CAS-13883: casadocs task and tool pages: parameter (multi)types are broken in releases >=6.4.0 #64

Merged
merged 5 commits into from
Sep 23, 2022

Conversation

FedeMPouzols
Copy link
Contributor

@FedeMPouzols
Copy link
Contributor Author

FedeMPouzols commented Sep 21, 2022

The build of this branch (I just merged master before opening the PR) failed, and the 'latest' build started failing yesterday: https://readthedocs.org/projects/casadocs/builds/
There seems to be some pandoc problem, but the error messages look vaguely familiar or similar to the errors we were getting when the casa6 repo was not public (around a couple of weeks ago).

@FedeMPouzols
Copy link
Contributor Author

FedeMPouzols commented Sep 21, 2022

The issue in recent builds of casadocs comes from pypandoc (download_pandoc() function), which has stopped working after github updated its release download pages. Issue: JessicaTegner/pypandoc#295, fix being worked on: JessicaTegner/pypandoc#296

Once there is a release of pypandoc with this fix, casadocs should update its requirements.txt to use it.

@bemonts
Copy link
Contributor

bemonts commented Sep 21, 2022

Thanks @FedeMPouzols for figuring out the problem. Do you know where we can track the status for release of pypandoc with fix?

@smcastro
Copy link
Contributor

Thanks Federico. The changes look good to me, although it would be better to wait for the build to be fixed to see the rendered pages.

@FedeMPouzols
Copy link
Contributor Author

Yes, the pypandoc fix is for now in this PR to the pypandoc repo: JessicaTegner/pypandoc#296

@FedeMPouzols
Copy link
Contributor Author

@bemonts , @smcastro : I've merged master into this branch and the casadocs buildfrom this branch has now passed. The rendered docs look good to me.

(With this temporary change to hardcode the url to download pandoc: 3f98ee7 the 'latest' builds are working now)

After the upcoming CASA release and/or depending when the updated pypandoc release becomes available we have to remember to remove the hardcoded url and use again a proper version tag (assuming the upgrade of pypandoc to the latest release is harmless, which I would expect). I'd suggest we create at least an issue in this repo to keep track of that.

@FedeMPouzols
Copy link
Contributor Author

Merging this branch for 6.5.2.

As discussed in the chat, after this temporari fix: 3f98ee7, the casadocs builds are working again. After merging master with that update into this branch the docs were rendered again and they looked fine.

@FedeMPouzols FedeMPouzols merged commit bb11f46 into master Sep 23, 2022
@FedeMPouzols FedeMPouzols deleted the CAS-13883 branch September 23, 2022 07:08
@bemonts
Copy link
Contributor

bemonts commented Sep 23, 2022

Thanks, @FedeMPouzols !!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants