Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add NewWatcherWithConfig() #25

Merged
merged 4 commits into from
Jan 26, 2024
Merged

feat: add NewWatcherWithConfig() #25

merged 4 commits into from
Jan 26, 2024

Conversation

yuetchn
Copy link
Contributor

@yuetchn yuetchn commented Jan 26, 2024 •
edited by hsluoyz
Loading

Fix: #24

@yuetchn yuetchn mentioned this pull request Jan 26, 2024
Closed
@coveralls
Copy link

coveralls commented Jan 26, 2024 •
edited
Loading

Coverage Status

coverage: 84.043% (+3.7%) from 80.303%
when pulling f888e25 on yuetchn:master
into fcbdc9d on casbin:master.

@hsluoyz hsluoyz closed this Jan 26, 2024
@hsluoyz hsluoyz reopened this Jan 26, 2024
@hsluoyz hsluoyz changed the title feat: Added configuration-based constructors feat: add NewWatcherWithConfig() Jan 26, 2024
@CLAassistant
Copy link

CLAassistant commented Jan 26, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@hsluoyz
Copy link
Member

hsluoyz commented Jan 26, 2024

@yuetchn plz also add the new API usage to README.md

@yuetchn
Copy link
Contributor Author

yuetchn commented Jan 26, 2024 •
edited by hsluoyz
Loading

@yuetchn plz also add the new API usage to README.md

the README.md has been updated with a new usage.

@hsluoyz hsluoyz merged commit ace56e7 into casbin:master Jan 26, 2024
7 checks passed
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 2.3.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Optimization: Is it possible to add a profile-based constructor?
4 participants
@yuetchn @coveralls @CLAassistant @hsluoyz