-
-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change default v7 to v5 #179
Comments
@tangyang9464 what's your opinion? |
Maybe we need to extend #168 to a more flexible schema? |
@JalinWang plz revert PR: #157 |
@JalinWang I think so. |
@hsluoyz I think we should extend #168 to support v7 instead of revert |
every thanks , what time for merge #168 |
@tangyang9464 @JalinWang I still think we should make it simple and just use up to v5 element. The user can fork the library and extend elements as they want. Supporting customizing it will take a lot of efforts for our maintainers team. We may need two weeks to just finish: #180 and this is only one adapter. Remember we have 20+ adapters only for Golang and it will be a disaster to support them all. Not to mention we have 10 more other languages, Java, Python, Node.js, PHP, .NET and each language will have a bunch of adapters. This is something we cannot afford to do with the current development team. Moreover, I don't think it's very meaningful. Just fork it and extend to v7 or v17. It's already so easy. Don't waste tons of our development team's efforts to just fix this small issue. |
i want change default v7 struct to v5 ,use NewAdapterByDBWithCustomTable is not work
The text was updated successfully, but these errors were encountered: