feat: support customized table #168
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tangyang9464 @closetool @sagilio please review |
|
@basimsahaf @tangyang9464 plz review |
tangyang9464
requested changes
Jun 20, 2022
basimsahaf
reviewed
Jun 22, 2022
basimsahaf
reviewed
Jun 22, 2022
basimsahaf
reviewed
Jun 22, 2022
tangyang9464
requested changes
Jun 26, 2022
JalinWang
changed the title
tangyang9464
approved these changes
Jun 27, 2022
|
@basimsahaf plz review |
Closed
|
@JalinWang fix conflicts:
|
@hsluoyz Done |
|
@JalinWang fix:
|
|
@JalinWang Does this PR support custom v0-v5？ |
Currently, no. I'll work on it in days. |
@hsluoyz SORRRRY but now it's okay. Annoying conflict resolving 😣. |
|
@JalinWang this PR makes code too complicated just to implement a not-so-important extra functionality, gorm-adapter is a benchmarking example and it should be kept simple. I suggest we putting this code into another adapter repo |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #167