Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: bump go-redis from v8 to v9 #45

Merged
merged 5 commits into from
Mar 26, 2023
Merged

feat: bump go-redis from v8 to v9 #45

merged 5 commits into from
Mar 26, 2023

Conversation

cwp0
Copy link
Contributor

@cwp0 cwp0 commented Mar 26, 2023

Fix: #42

@casbin-bot
Copy link
Member

@tangyang9464 @JalinWang @imp2002 please review

@CLAassistant
Copy link

CLAassistant commented Mar 26, 2023

CLA assistant check
All committers have signed the CLA.

@cwp0 cwp0 changed the title build: bump github.com/redis/go-redis/v9. fix: bump github.com/redis/go-redis/v9. Mar 26, 2023
@cwp0 cwp0 changed the title fix: bump github.com/redis/go-redis/v9. build: bump github.com/redis/go-redis/v9. Mar 26, 2023
@hsluoyz hsluoyz changed the title build: bump github.com/redis/go-redis/v9. feat: bump go-redis from v8 to v9 Mar 26, 2023
@hsluoyz hsluoyz merged commit 122e364 into casbin:master Mar 26, 2023
@sixcolors
Copy link
Contributor

Hi, I just wanted to bring to your attention that this pull request appears to be a copy of my open pull request #43. Just using an unreleased v9 commit. While I appreciate the effort to contribute to the project, I would appreciate it if proper credit was given for my original work. Thank you.

@hsluoyz
Copy link
Member

hsluoyz commented Mar 26, 2023

@sixcolors hi, is it acceptable to let the PR contain your original commit (with your original author info) including other new commits? Or do you think the PR should be discarded totally? If the latter is your choice, we will revert all related PRs for now.

@sixcolors
Copy link
Contributor

sixcolors commented Mar 26, 2023

@sixcolors hi, is it acceptable to let the PR contain your original commit (with your original author info) including other new commits? Or do you think the PR should be discarded totally? If the latter is your choice, we will revert all related PRs for now.

@hsluoyz either option is acceptable, thank you.

#43 was left open in hope that go-redis would add a tagged release. Because go mod tidy will always update to the highest semantic release of a direct dependency. Thus other projects using redis-watcher would then also be updated to a non release commit of go-redis.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

update to github.com/redis/go-redis/v9
5 participants