-
Notifications
You must be signed in to change notification settings - Fork 919
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use react 15.0.1 #132
use react 15.0.1 #132
Conversation
wrote some more on |
Why not |
all of the code uses strings so far, i did not want to break that pattern. @casesandberg if you would prefer numbers instead of strings i can update my pr oh and this will only help for the bottom, left, right and top values, the Absolute: will still have to be set using px, this maybe should be added to the Absolute function in reactcss? |
@Kerumen This feature is being deprecated by React in the future: https://facebook.github.io/react/blog/2016/04/07/react-v15.html#new-helpful-warnings and facebook/react#5140 |
@joshdover |
@Kerumen ah not sure how I missed that 👍 |
Is anyone still working on this PR? I'm waiting for this to be landed.. |
Maintainer hasn't had any github activity since April 1st 😦 |
@casesandberg Why was this closed? #126 doesn't fix the issue that this resolves, which is all the deprecation warnings |
update css positional values from 0 to 0px,
for bottom, left, right, top and Absolute values.