Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use react 15.0.1 #132

Closed
wants to merge 7 commits into from
Closed

use react 15.0.1 #132

wants to merge 7 commits into from

Conversation

jaeh
Copy link
Contributor

@jaeh jaeh commented Apr 17, 2016

update css positional values from 0 to 0px,
for bottom, left, right, top and Absolute values.

@jaeh
Copy link
Contributor Author

jaeh commented Apr 17, 2016

wrote some more on
#114 (comment)
about the tests failing

@Kerumen
Copy link

Kerumen commented Apr 17, 2016

Why not top: 0 instead of top: '0px'? It's more concise and there is no need to specify the px unit because it's implicitly set when written in number format.

@jaeh
Copy link
Contributor Author

jaeh commented Apr 17, 2016

all of the code uses strings so far, i did not want to break that pattern.

@casesandberg if you would prefer numbers instead of strings i can update my pr

oh and this will only help for the bottom, left, right and top values, the Absolute: will still have to be set using px, this maybe should be added to the Absolute function in reactcss?

@joshdover
Copy link

@Kerumen This feature is being deprecated by React in the future: https://facebook.github.io/react/blog/2016/04/07/react-v15.html#new-helpful-warnings and facebook/react#5140

@Kerumen
Copy link

Kerumen commented Apr 18, 2016

@joshdover top: '0' is deprecated (notice the string value) but top: 0 is not (notice the number value). Unitless number values like width: 300 are unchanged.

@joshdover
Copy link

@Kerumen ah not sure how I missed that 👍

@zimond
Copy link

zimond commented Apr 25, 2016

Is anyone still working on this PR? I'm waiting for this to be landed..

@joshdover
Copy link

Maintainer hasn't had any github activity since April 1st 😦

This was referenced May 2, 2016
@joshdover
Copy link

joshdover commented May 10, 2016

@casesandberg Why was this closed? #126 doesn't fix the issue that this resolves, which is all the deprecation warnings

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants