remove isValidHex validation from Swatches #688
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes
Swatches
to be consistent withGithub
andCircle
.This fixes #488 and makes it up to the user to control the color values via props, letting you use hex8 or rgba in these components (if your use case supports it) since the component itself does not need to validate an end-user hex6 text input.
It could also make sense to have the
onChange
property of these components return a color string value instead ofcolor.hex
but that would be a breaking change to the interface. May be better for this to just be an undocumented feature for those of us that need it? Meaning that these components are "dumb" and will pass through whatever values we feed in.