Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed defaultProps. #893

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ofps
Copy link

@ofps ofps commented Nov 28, 2023

This PR removes defaultProps from every function component, solving issue #888 .
Changes in package.json were needed to successfully build and test the project.

@ofps ofps force-pushed the fix/remove-function-component-default-props branch from 4f84b36 to 1d887a1 Compare November 29, 2023 10:14
@Micode360
Copy link

I don't know if this was merged with the main branch but Installed this package and got the same error for checkboard and one more. Doesn't seen resolved.

@ofps
Copy link
Author

ofps commented Dec 1, 2023

Hi @Micode360

Thank you for your feedback.

If you installed this branch it's possible your version manager kept using the original since the version did not change.

I have successfully removed all warnings from one of my projects by using the main branch of my fork: fernandojpps/react-color, can you see if that works for you?

Let me know if that fixes the warnings for you.

There is another warning with the Checkboard component that this PR doesn't fix, it's related to the use of canvas to generate the checkboard, which only works on the client. I actually tested some solutions for that but I'm not happy with the results yet. That will probably be a future PR.

@Micode360
Copy link

@fernandojpps okay. I ended using another. But if I need it again, I will install it.

@fandredev
Copy link

can anyone check this please?

@PhamMinhKha
Copy link

This PR removes defaultProps from every function component, solving issue #888 . Changes in package.json were needed to successfully build and test the project.
How can I use this update? Could you provide specific guidance to help me? Thank you very much.

@alxAgu
Copy link

alxAgu commented Jun 16, 2024

bump

@mxmp210
Copy link

mxmp210 commented Jun 17, 2024

This needs to be merged in order to keep up with react.

@DarthSnufkin
Copy link

yes please

@seemX17
Copy link

seemX17 commented Jun 20, 2024

@casesandberg Can we have this merged please?
@fernandojpps Cn you provide a patch fix?

@clararabello
Copy link

any updates?

@rohitkrishna094
Copy link

@casesandberg Can you take a look at this when you are free? I think it can be merged.

Thanks

@isaackogan
Copy link

begging

@vicmassy
Copy link

interested in this getting merged also!

@MaSobkowiak
Copy link

Bump

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.