Bump examples QC submodule pointer and review recently added examples #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This bump incorporates all updates done to fix SHACL validation issues against CASE 1.1.0. A follow-on patch will regenerate Make-managed files. References: * casework/CASE-Examples#117 * casework/casework.github.io#225 Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
References: * casework/CASE-Examples#117 * casework/casework.github.io#225 Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
This patch also aligns the Make recursion pattern for the website with the CASE-Examples test directory. This patch will fail `make check` on its own. Follow-on patches will add the support directories and regenerate Make-managed files. Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
A follow-on patch will regenerate Make-managed files. Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
ajnelson-nist
changed the title
An example in CASE-Examples uses `case-investigation:wasDerivedFrom` without setting up a provenance chain. This triggered a missing-entity error in `case_prov_dot.py`. (The example is being added to review in another PR in progress.) When `wasDerivedFrom` is mapped from an explicit statement in CASE to PROV-O, PROV-O class assignments should be "inferred" (generated) for the triple's subject and object. No effects were observed on Make-managed files. Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
A follow-on patch will regenerate Make-managed files. Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.