-
Notifications
You must be signed in to change notification settings - Fork 476
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make completions work with an alias #1035
Conversation
Thanks for the PR! The completions are actually generated by For now though, the changes need to be added to the |
Thank you for the comments! I fixed this PR and added an upstream PR to clap to fix it for other projects. Note that I confirmed that the checked-in completions.bash file does not change when re-running completions with the updated completion function included in this PR. |
Nice, one comment, but otherwise looks great. |
Co-authored-by: Casey Rodarmor <casey@rodarmor.com>
@casey Wanted to make sure this doesn't get lost in the ether - anything blocking merging this in? |
Thanks for pinging this issue! I didn't get a notification when you made the change to this branch, but it looks good to go. I hit the auto-merge button so it should merge when the tests pass. |
The tests failed, it looks like because there's a formatting diff. |
Head branch was pushed to by a user without write access
Oops, thanks. I ran tests but not formatting. Fixed. It looks like me pushing that caused the auto-merge to reset. Thank you! |
Right now if you use the README recommended alias,
alias j=just
, in bash, it stops shell completion from working.This is a small PR to allow the bash completions script to work with an alias, and adds instructions in the README for how to use it.