Don't hardcode homebrew prefix #1295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I haven't forgotten about this! Would like to make this change, but I wanted to do a bit of research on Homebrew first. Will reply soon. |
|
The problem with this suggestion is that However, I have learned that currently, Homebrew can be installed in THREE different places, depending on platform:
Sooo… I guess that needs to be mentioned in the README text too, since this code will not work for the majority of users right now who are on Intel Macs. |
|
See #1304 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @nk9, does this look better? This avoids hard-coding the homebrew prefix of
/opt/homebrew, and just callingbrew shellenv. I think this might be necessary on systems where brew is in/usr/local.