Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eliminate lazy_static #1442

Merged
merged 12 commits into from
Dec 16, 2022
Merged

Eliminate lazy_static #1442

merged 12 commits into from
Dec 16, 2022

Conversation

camsteffen
Copy link
Contributor

Just a little cleanup.

@casey casey enabled auto-merge (squash) December 12, 2022 18:30
auto-merge was automatically disabled December 12, 2022 20:24

Head branch was pushed to by a user without write access

@camsteffen
Copy link
Contributor Author

const Mutex::new requires Rust 1.63

@casey
Copy link
Owner

casey commented Dec 15, 2022

Thanks for the PR!

I like this change, but I don't think it's worth bumping the MSRV so aggressively. 1.65 was released on Nov. 3, so a little over a month ago. Just doesn't have a formal MSRV policy, but I think I'd like to support at least the last couple of Rust releases.

@casey casey closed this Dec 15, 2022
@camsteffen
Copy link
Contributor Author

It could be 1.63.

@casey casey reopened this Dec 15, 2022
@casey
Copy link
Owner

casey commented Dec 15, 2022

I'm rethinking this. I've tried to be conservative with my MSRV policy, but I don't have a super clear memory for why. I think I want to revisit the reasons for that conservatism, come up with a concrete policy (e.g. support last two Rust releases) and then we can figure out hat new policy allows merging this. Hang tight!

@camsteffen
Copy link
Contributor Author

I would think MSRV doesn't matter much since this isn't a library?

@casey
Copy link
Owner

casey commented Dec 15, 2022

Just is packaged for a number of distros, and if their version of rust lags behind Just's MSRV, they won't be able to package it, and users won't be able to build it from source. I'm not sure if this is a problem in practice though.

@casey casey enabled auto-merge (squash) December 16, 2022 00:19
@casey casey disabled auto-merge December 16, 2022 00:27
@casey casey enabled auto-merge (squash) December 16, 2022 00:28
@casey casey disabled auto-merge December 16, 2022 00:51
@casey casey merged commit 216df31 into casey:master Dec 16, 2022
@casey
Copy link
Owner

casey commented Dec 16, 2022

Based on surveying the internet, it seems like a conservative MSRV isn't super important for binary crates, so I decided to just switch MSRV to stable.

Merged, with a bunch of fixes for latest clippy.

Thanks for the PR!

@camsteffen camsteffen deleted the no-lazy-static branch December 16, 2022 03:25
benmoss added a commit to benmoss/just that referenced this pull request Jan 11, 2023
1.63 is required by Mutex::new added in casey#1442
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants