Fix windows support in www/install.sh #1474
Conversation
The current version of install.sh does not quite fully support installing windows binaries. This change fixes that by: - handling the fact that windows releases are zips not tarballs - handling `uname -s` output being funky on MINGW compiled bash Additionally, it adds a step to the CI tests to test install.sh works on multiple platforms. These tests uncovered that `need rev` was failing on windows bash. However, `rev` is not actually used any more, so I removed that and `need basename`, as that doesn't seem to be used any more either.
This follows the official just instructions for [installing pre-built binaries](https://github.com/casey/just#pre-built-binaries). However, the current version of https://just.systems/install.sh doesn't quite work in windows. I have fixed that and [proposed the changes upstream](casey/just#1474), and include a copy of the fixed script in this repo for now. As part of this, have added tests for this action, which runs on multiple OSs, in order to test the cross platfoem installation Also, allow installing a specific version of just.
|
This is a great PR, thank you! I think Windows support in install.sh has been broken for a long time. (Possibly forever, and nobody actually tried it / noticed / reported it 😅) |
|
Thanks for your attention, and the merge 🎉 For context, in case it's of interest, the reason behind this fix is we were using https://github.com/extractions/setup-just to install just in our GH actions. However, under the hood, this action uses the Github API to get the current release. Due to Github runners sharing IPs, we would relatively frequently get rate limit errors in our CI. The documented workaround is pass our GITHUB_TOKEN as a parameter, but we're not keen to send that to a third party action. So, we ended up moving to using our own action, based on https://just.systems/install.sh to install the release (as it uses curl rather than GH API), thus avoiding the rate limits. However, we have some projects that need Windows CI, hence this PR. Thanks for just, its great! |
The current version of install.sh does not quite fully support installing windows binaries.
This change fixes that by:
uname -soutput being funky on MINGW compiled bashAdditionally, it adds a step to the CI tests to test install.sh works on multiple platforms. These tests uncovered that
need revwas failing on windows bash. However,revis not actually used any more, so I removed that andneed basename, as that doesn't seem to be used any more either.