Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support escaping newlines #1551

Merged
merged 1 commit into from
Jul 25, 2023
Merged

Support escaping newlines #1551

merged 1 commit into from
Jul 25, 2023

Conversation

ids1024
Copy link
Contributor

@ids1024 ids1024 commented Feb 17, 2023

Fixes #1157.

casey
casey requested changes Jun 13, 2023
View reviewed changes
Copy link
Owner

@casey casey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Can you add tests that cover:

  1. Escaping a \r\n
  2. The unpaired \r\n error
  3. The invalid escape sequence error?

src/lexer.rs Outdated Show resolved Hide resolved
@ids1024
Copy link
Contributor Author

ids1024 commented Jul 24, 2023

Updated.

@casey casey enabled auto-merge (squash) July 25, 2023 09:05
@casey casey merged commit 30bcf28 into casey:master Jul 25, 2023
5 checks passed
@casey
Copy link
Owner

casey commented Jul 25, 2023

Nice, merged!

@nk9 nk9 mentioned this pull request Jul 26, 2023
Open
@laniakea64 laniakea64 mentioned this pull request Dec 2, 2023
Merged
@jraygauthier jraygauthier mentioned this pull request Jan 10, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@casey casey casey requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add new line escapes
2 participants
@ids1024 @casey