Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README to clarify state of vim-polyglot's packaging of vim-just #1644

Merged
merged 1 commit into from
Oct 9, 2023
Merged

Update README to clarify state of vim-polyglot's packaging of vim-just #1644

merged 1 commit into from
Oct 9, 2023

Conversation

laniakea64
Copy link
Contributor

@laniakea64
Copy link
Contributor Author

Hi @casey do you need anything else from me in order to review and merge this? Thanks - and thank you for just, it makes a much simpler and nicer workflow than other means of running dev tasks! 👍

@laniakea64
Copy link
Contributor Author

Hi @casey do you need anything else from me in order to review and merge this?

Would appreciate this answer, especially since this is my first time contributing to improve just documentation, so I don't yet have a good sense of what's wanted in such pull requests. Thank you for your review.

@laniakea64
Copy link
Contributor Author

Maybe few things weren't clear from the context link:

  • The author of this PR (me) is co-maintainer of vim-just since March 2023.

  • Regarding my original comment about this part of just documentation, note that the difference between vim-just and vim-polyglot's justfile support is already substantial. There have been major changes in vim-just since June 2021: current vim-just supports highlighting all syntaxes of just 1.14.0 (and our just-prerelease branch additionally supports all syntaxes added since then up to this just revision), plus many bug fixes and other enhancements.

  • There are other areas just documentation could be improved (including documenting pre-release syntaxes, but some other things too). After this PR is reviewed & merged, I'm hoping to make another PR containing those improvements.

@casey
Copy link
Owner

casey commented Oct 9, 2023

Thanks for the PR! If vim-polyglot is unmaintained, then we should probably just remove it from the readme. Want to remove it instead of adding a note?

Copy link
Owner

@casey casey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment.

@laniakea64
Copy link
Contributor Author

If vim-polyglot is unmaintained, then we should probably just remove it from the readme.

Done. Thanks for your input 🙂

@casey casey enabled auto-merge (squash) October 9, 2023 04:06
Copy link
Owner

@casey casey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good!

@casey
Copy link
Owner

casey commented Oct 9, 2023

Also, can you update to the latest master?

@casey casey merged commit 41c52f9 into casey:master Oct 9, 2023
5 checks passed
@laniakea64 laniakea64 deleted the doc branch October 9, 2023 04:18
@casey
Copy link
Owner

casey commented Oct 9, 2023

Merged, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants