Add rust-toolchain file #1663
Closed
Add rust-toolchain file #1663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since this should be provided by the rust-toolchain.toml file now
Has to be 'rust-toolchain' not 'rust-toolchain.toml'
|
I actually kind of like not pinning the latest stable version of rust in CI. On the one hand CI does break periodically when new lints are introduced, on the other hand, that reminds me to fix the lints and update to the latest version of Rust. I think overall I'm inclined not to do this, unless there's some way to automate a reminder to update Rust. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a
rust-toolchain.tomlfile to the repo, pinned to the current rust stable version as of today, which is 1.72.0.This codifies exactly what version of rust will definitely build
just, and prevents the problem that when the current stable version of rust changes, the next time CI runs, the new version of rust might pull in new clippy lints that the codebase won't pass, causing CI failures unrelated to an actual build problem. This does mean that it will be necessary to periodically manually updaterust-toolchain.tomlto be up-to-date with the latest rust stable version, but I think that's a virtue rather than a vice.