-
Notifications
You must be signed in to change notification settings - Fork 476
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optional command color #1670
Optional command color #1670
Conversation
@frederikhors Do you mind doing a quick review of this draft MR to enable colored output for recipe lines? You were the one who originally opened the issue, and I figure you might be a little more experienced with Rust than I am. |
I'm sorry. I'm not using it anymore. |
@frederikhors , no problem at all, and thank you for your reply. If I may ask, what do you use now instead of just? |
I was going to create an issue for this but there already is an MR, thanks @avi-cenna ! A question: why the limitation to cyan and purple instead of all the "base" colours usually found in terminal emulators ? |
@poliorcetics I wanted to start off with just a couple colors until someone could review and confirm that my approach was reasonable. Thank you for the review. Are you a maintainer on this project? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, added a bunch of comments. We should also add all the rest of the colors that ansi_term
supports.
Co-authored-by: Casey Rodarmor <casey@rodarmor.com>
Co-authored-by: Casey Rodarmor <casey@rodarmor.com>
Co-authored-by: Casey Rodarmor <casey@rodarmor.com>
Co-authored-by: Casey Rodarmor <casey@rodarmor.com>
Co-authored-by: Casey Rodarmor <casey@rodarmor.com>
Co-authored-by: Casey Rodarmor <casey@rodarmor.com>
Co-authored-by: Casey Rodarmor <casey@rodarmor.com>
Co-authored-by: Casey Rodarmor <casey@rodarmor.com>
@casey thanks for the review. I have applied your suggestions as much as possible, and added the additional colors. I've also added one integration test for the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, looks great! I made a couple changes: I sorted the command color values alphabetically and reworded the help text message. Merging now!
Draft MR which attempts to resolve #1186, ie allowing for colored command output. I can add to the list of available colors, but was hoping to get a quick review first to make sure my approach is sensible.