Chooser: Pass justfile path to preview command for default chooser #1759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Qeole
force-pushed
the
pr/justfile-path-chooser-preview
branch
2 times, most recently
from
a6c73d4
to
c648b0d
Compare
casey
requested changes
Dec 13, 2023
Qeole
force-pushed
the
pr/justfile-path-chooser-preview
branch
from
c648b0d
to
505be59
Compare
|
I'm getting a failure on the CI test this time, |
The default chooser is fzf, and we pass it a command to generate the preview with "just --show" from the recipe name. This has been working well as long as we rely on the default justfile available in the directory, given that the preview command can find it too. However, passing "--chose" alongside "--justfile" to select a specific file results in the preview command not being able to find the right justfile to process. To address this issue, we turn the const string defining the preview command into a function that takes the internal representation of the justfile as an argument, and updates the preview command with the right file. Fixes: 5f9ac39 ("Use `just --show` in default chooser (casey#1539)") Suggested-by: Casey Rodarmor <casey@rodarmor.com>
Qeole
force-pushed
the
pr/justfile-path-chooser-preview
branch
from
505be59
to
e06e12a
Compare
casey
approved these changes
Dec 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default chooser is fzf, and we pass it a command to generate the preview with
just --showfrom the recipe name. This has been working well as long as we rely on the default justfile available in the directory, given that the preview command can find it too. However, passing--chosealongside--justfileto select a specific file results in the preview command not being able to find the right justfile to process.To address this issue, we turn the const string defining the preview command into a function that takes the internal representation of the justfile as an argument, and updates the preview command with the right file.
Fixes: #1638