Support "::" in Bash completions #1863
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
... oh. That completion file is generated by clap. Right. |
|
Gonna be fun making those changes using only search/replacements in |
crdx
force-pushed
the
completion-colon-support
branch
from
d4390cb
to
12cc350
Compare
|
Should be good now. |
|
Nice, LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modules use
::as the separator, which is considered a wordbreak character in Bash. This means they can't be completed by default, as colon is considered the end of a completion.The (very) bad way to solve this is by globally modifying
COMP_WORDBREAKSto remove the colon character. Not only is this bad because it can have unintended side-effects, but git's completion script actually adds the colon back if it detects it's not present.So Bash made available the
_get_comp_words_by_refand__ltrim_colon_completionsfunctions for this purpose. They're not present on every platform, in which case we fall back to the original method.