Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos discovered by codespell #1872

Merged
merged 3 commits into from
Jan 25, 2024
Merged

Fix typos discovered by codespell #1872

merged 3 commits into from
Jan 25, 2024

Conversation

cclauss
Copy link
Contributor

@cclauss cclauss commented Jan 24, 2024

% codespell --ignore-words-list=crate,fo,ser --write-changes

CHANGELOG.md Outdated Show resolved Hide resolved
@casey casey enabled auto-merge (squash) January 25, 2024 00:01
@casey
Copy link
Owner

casey commented Jan 25, 2024

Very nice!

@casey casey merged commit ebead95 into casey:master Jan 25, 2024
5 checks passed
@cclauss
Copy link
Contributor Author

cclauss commented Jan 25, 2024

It is unfortunate to put the misspelling in the commit message like:

Fix typo: argumant -> argument (#1257)
Fix readme typo: interpetation -> interpretation (#578)
Fix typo: chracter -> character (#561)

because then it is difficult to find that misspelling again with automated tools.

@cclauss cclauss deleted the codespell branch January 25, 2024 00:04
@casey
Copy link
Owner

casey commented Jan 25, 2024

Yah, agreed. Definitely my fault, I usually write the commit messages. And we can't really run codespell as an action on the commit messages, since I usually write them from the interface on github.com in the squash-and-merge button.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants